feat: Support forked github workflow builds#400
Open
disaac wants to merge 2 commits into
Open
Conversation
* Updated the build.yml workflow to conditionally build and push docker image to ghcr if it is running on a forked version. * Added the PROJECT_MAINTAINER_REPO as an environment variable and determine whether its a fork and what to name the image based on this. * Instead of using run script to obtain tags using the docker/metadata-action maintaining the same conventions used. This would make additional tagging metadata easily addeded to the images if desired. * Updated all the github action versions to the latest major versions. * Using github outputs instead of environment variables in steps. Closes Github Issue: lardbit#399
* Updated the Dockerfile to properly reference the correct prebuilt frontend tag. Was previously hardcoded resulting in a nefarious image that used the wrong prebuilt image if built on a fork. Fixes Github Issue: lardbit#399
Owner
|
This sounds great. Did the test runs look and work ok on ghcr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Github Issue: #399