[13.x] Allow faking DNS lookups in validation rules#60879
Merged
Conversation
SjorsO
commented
Jul 24, 2026
| ); | ||
| $v = new Validator($trans, $data, ['x' => 'active_url']); | ||
| $this->assertEquals($outcome, $v->passes()); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This mock was added 4 years ago in #43781 to solve flaky tests in Laravel's own test suite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of our tests are flaky because the
active_urlvalidation rule does a real DNS lookup that can randomly fail (even for a reliable domain like google.com). There is currently no straightforward way to fake these DNS lookups.This PR adds
Validator::fakeDnsLookups(), which makesactive_urlandemail:dnsskip the DNS lookup and treat it as successful. Everything else about these rules keeps working: malformed URLs and emails still fail.