[13.x] Add a #[BindWhen()] attribute to conditionally bind into the container#60862
Open
ziadoz wants to merge 14 commits into
Open
[13.x] Add a #[BindWhen()] attribute to conditionally bind into the container#60862ziadoz wants to merge 14 commits into
#[BindWhen()] attribute to conditionally bind into the container#60862ziadoz wants to merge 14 commits into
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
Contributor
|
Nice idea! #[BindWhenConfig(BetaPaymentGateway::class, 'features.payments.beta')] // <-- must be boolean |
Contributor
|
Have you considered to add the second parameter directly to |
Contributor
Author
@shaedrich I did consider it, but it didn't seem ideal having to either specify the |
ziadoz
marked this pull request as ready for review
July 22, 2026 15:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new
#[BindWhen]attribute, which makes it possible to do things that#[Bind]can't, since it's restricted to filtering environments. It relies on PHP 8.5, which allows static closures as attribute parameters.My use case is wanting to load different services and features for specific customers depending on configuration. The closure receives the container though, so it could be used for more complex binding scenarios.
The attributes are still processed in the order they're defined in the code:
Note: The failing DB tests aren't related as far as I can tell.