[13.x] Add InteractsWithData plainString method to retrieve data as a string#60861
Closed
devhammed wants to merge 2 commits into
Closed
[13.x] Add InteractsWithData plainString method to retrieve data as a string#60861devhammed wants to merge 2 commits into
plainString method to retrieve data as a string#60861devhammed wants to merge 2 commits into
Conversation
Member
|
Thanks for your pull request to Laravel! Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include. If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions! |
Contributor
Author
|
@taylorotwell Would you be open to making this changing the return value of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe the
stringmethod inInteractsWithDatashould be returning actual PHP strings instead of a Stringable instance, while we keepstrfor that purpose because there are genuine cases where I want a nullable string, but Stringable would have already converted it to an empty string so we end up having to check for empty string or go back to using theinputmethod. Still, since it has been used that way and changing the behaviour is a breaking change, it is only fair for us to have a way to retrieve typed data, just as there is for other types like integer, boolean, enums, arrays, etc.