Ignore commented-out entries when checking for existing MCP servers - #933
Open
lazerg wants to merge 1 commit into
Open
Ignore commented-out entries when checking for existing MCP servers#933lazerg wants to merge 1 commit into
lazerg wants to merge 1 commit into
Conversation
lazerg
force-pushed
the
fix/issue-932-commented-server-key
branch
from
August 11, 2026 12:24
1523992 to
26cc1b5
Compare
lazerg
force-pushed
the
fix/issue-932-commented-server-key
branch
from
August 11, 2026 12:50
26cc1b5 to
2630525
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
boost:install --mcpreports success but writes nothing when the server key only shows up in a commented-out line insidemcpServers. That happens when you disable a server and later run install to bring it back.serverExistsInContent()matches against the raw slice between themcpServersbraces, so// "laravel-boost": {...}counts as an existing entry and the server is filtered out before injection. The check now runs on the content with comments removed, and quoted strings are left alone so a//inside a value like"url": "https://example.com"still reads as real config rather than a comment.Fixes #932