fix(acp): normalize file change path expectation on macOS - #96
fix(acp): normalize file change path expectation on macOS#96AsperforMias wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
🟡 Not ready to approve
Canonicalization misses final-component symlinks, and the required sourceEventId validation was removed.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Canonicalizes ACP file-change paths across macOS and Linux and updates related assertions.
Changes:
- Resolves writable paths to canonical locations.
- Uses partial event matching while preserving event-count validation.
File summaries
| File | Description |
|---|---|
src/runtimes/acp/acp-file-system.ts |
Canonicalizes written and reported paths. |
tests/acp-file-system.test.ts |
Updates cross-platform path expectations. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
ab42173 to
691d43e
Compare
There was a problem hiding this comment.
🟢 Ready to approve
The focused portability fix satisfies the issue’s acceptance criteria without changing production behavior.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
|
@Yevanchen needs help for running CI |
There was a problem hiding this comment.
🟡 Not ready to approve
The revised process test no longer exercises the force-kill fallback because the descendant accepts SIGTERM.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Review details
Suppressed comments (1)
tests/openai-app-server-client.test.ts:966
- The descendant no longer ignores
SIGTERM, sostop()can take the early return after graceful termination (app-server-client.ts:634-645) and this test no longer exercises the advertised force-SIGKILLfallback. Keep aSIGTERMlistener installed so the descendant remains alive until the force-kill path, then retain the new PID-exit assertion to verify that fallback actually removed it.
writeFileSync(${JSON.stringify(descendantReadyPath)}, "ready");
setInterval(() => {}, 1000);
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Summary
Validation
Closes #93