feat: shared documents ingestion mode for IBM COS connectors hotfix#1955
Open
ricofurtado wants to merge 14 commits into
Open
feat: shared documents ingestion mode for IBM COS connectors hotfix#1955ricofurtado wants to merge 14 commits into
ricofurtado wants to merge 14 commits into
Conversation
* Update connector.py * update env in settings * fix webhook url of sharepoint
…bscriptions, change discovery) (#1867) * fix: alias legacy /connectors/google/webhook to google_drive and reload connections store on webhook channel lookup miss * Fix Sharepoint and Google Drive * fix: propagate deleted items from SharePoint/OneDrive webhook delta query Main's delete-event coverage (#1852) expects handle_webhook to return deleted file ids so sync_specific_files can run its deleted-at-source cleanup (get_file_content -> 404 -> delete indexed chunks). The delta implementation skipped deleted items; now deleted files propagate and deleted folders stay excluded. * use logging _config * Update test_webhook_type_alias.py
…nRAG-API-JWT header (#1874) * use fallback header * Notes on new header * raises http exception for missing jwt
…xed without an owner
Improving error return Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…ails for shared documents
… related functionality
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
frontend
ricofurtado
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new permission,
knowledge:delete:anonymous, to enable deletion of ownerless (shared) knowledge documents, and updates both backend and frontend to support shared documents and their management. The changes ensure that only users with the correct permission (typically admins) can delete shared documents, and add UI options for making documents available to all users in the instance (for IBM COS ingestion). The permission logic and API endpoints are refactored to handle these new capabilities.Backend: Permissions and Deletion Logic
knowledge:delete:anonymous, via Alembic migration, and granted it to the admin role. This enables deletion of ownerless shared documents without affecting the existingknowledge:delete:anypermission.knowledge:delete:ownandknowledge:delete:anonymouspermissions, using the appropriate OpenSearch queries and clients depending on the user's permissions. [1] [2] [3] [4] [5] [6] [7] [8]Backend: Shared Document Ingestion
sharedflag to connector sync APIs (only supported for IBM COS), allowing ingestion of documents without an owner so they are visible to all users. The backend enforces that this flag is only valid for theibm_cosconnector. [1] [2] [3] [4] [5]Frontend: Shared Document Support
sharedproperty to ingestion settings and UI components, allowing users to mark documents as shared during ingestion (IBM COS only). [1] [2] [3] [4] [5] [6] [7] [8] [9]These changes collectively enable secure creation, visibility, and deletion of shared documents in OpenRAG, with appropriate permission checks and user interface support.