fix: pass windows appdata/localappdata into mcp child env - #599
Open
Sudip Kandel (sudipawtg) wants to merge 2 commits into
Open
fix: pass windows appdata/localappdata into mcp child env#599Sudip Kandel (sudipawtg) wants to merge 2 commits into
Sudip Kandel (sudipawtg) wants to merge 2 commits into
Conversation
APPDATA and LOCALAPPDATA are commonly required by Windows MCP servers for config/cache paths. Forward them in the stdio child allowlist.
🦋 Changeset detectedLatest commit: 042134a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Colin Francis (colifran)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #598
Stdio MCP children already receive
USERPROFILE/HOMEPATH/HOMEDRIVE, but notAPPDATAorLOCALAPPDATA. Many Windows MCP servers need those to resolve config and cache directories.This adds both keys to
CHILD_ENV_ALLOWLISTand extendstest/mcp-client.test.ts. Credential filtering is unchanged.Verified with
pnpm exec vitest run test/mcp-client.test.ts(6 passed).