feat: add LangSmith APAC region to setup and allowlist - #596
Open
Sudip Kandel (sudipawtg) wants to merge 1 commit into
Open
feat: add LangSmith APAC region to setup and allowlist#596Sudip Kandel (sudipawtg) wants to merge 1 commit into
Sudip Kandel (sudipawtg) wants to merge 1 commit into
Conversation
Offer APAC alongside US/EU in the init wizard, persist apac.api.smith.langchain.com in committed workspace config, and allowlist that host in sanitizeLangSmithApiBaseUrl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #593
LangSmith setup only offered US and EU. APAC workspaces use
https://apac.api.smith.langchain.comand were missing from the wizard and host allowlist.This change:
LangSmithRegionwithapacapiBaseUrlfor APAC workspaces inopenwiki/.langsmith.jsonapac.api.smith.langchain.cominsanitizeLangSmithApiBaseUrlVerified with
pnpm test(920 passed).