fix: sanitize terminal control sequences in streamed Markdown - #595
Open
Sudip Kandel (sudipawtg) wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 179c512 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sudip Kandel (sudipawtg)
force-pushed
the
sudipawtg/fix/sanitize-markdown-terminal-controls
branch
from
August 5, 2026 09:47
ff10b71 to
065cfbc
Compare
Prevent model/repo-influenced CLI output from injecting OSC/CSI/C0 sequences (including OSC 52) into developer terminals.
Sudip Kandel (sudipawtg)
force-pushed
the
sudipawtg/fix/sanitize-markdown-terminal-controls
branch
from
August 5, 2026 09:47
065cfbc to
179c512
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #540
Streamed assistant Markdown could pass ESC/CSI/OSC sequences (including OSC 52 clipboard writes) into Ink and the user's terminal. Model output can be influenced by repository and connector content, so this crosses a trust boundary.
Sanitize untrusted Markdown at the
MarkdownTextboundary before lexing: strip ESC/CSI/OSC/DCS-family sequences and unsafe C0/C1 controls, while preserving newlines and tabs. Ink's own styling is unchanged.Verified with
pnpm run format,pnpm run lint:check, andpnpm test(including newtest/terminal-sanitize.test.tscoverage for OSC 52/8, CSI clear/cursor, BEL, CR, C1 controls, incomplete OSC tails, and code-fence/inline cases).AI assistance: used for drafting the implementation; changes were manually reviewed and verified locally.