fix: exclude unmeasurable LangSmith runs from outliers - #554
Open
Gautam Sharma (GautamSharma99) wants to merge 1 commit into
Open
fix: exclude unmeasurable LangSmith runs from outliers#554Gautam Sharma (GautamSharma99) wants to merge 1 commit into
Gautam Sharma (GautamSharma99) wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: d5a1d3c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #544.
LangSmith sampling used
latencyMs(run) ?? -1while calculating and filling the latency-outlier slice. When there were fewer measurable runs than the outlier budget, incomplete roots were labeled as slow despite having no latency evidence.Changes
Behavior
A run with no usable start/end timestamps can now be selected only as baseline (or omitted by the overall cap), never as a latency outlier. Every root in the outlier bucket has a defined measured latency.
Validation
pnpm run lint:checkpnpm run typecheckpnpm exec prettier --check(changed files)pnpm test— 67 files, 793 tests passed