fix: add deadlines to OAuth and ngrok fetches - #551
Open
Gautam Sharma (GautamSharma99) wants to merge 2 commits into
Open
fix: add deadlines to OAuth and ngrok fetches#551Gautam Sharma (GautamSharma99) wants to merge 2 commits into
Gautam Sharma (GautamSharma99) wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 58c0573 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #541.
OAuth discovery, dynamic client registration, authorization-code exchange, token refresh, ChatGPT OAuth exchange, and ngrok tunnel discovery previously called
fetch()without a deadline. A server that accepted a connection but never completed its response could therefore hang authentication and startup indefinitely.Changes
fetchWithAuthTimeout, a shared auth-network helper that:Behavior and safety
Transient provider failures are surfaced to the existing auth error paths instead of being retried implicitly. The timeout message identifies the operation and tells the user to check connectivity and retry. Existing endpoint validation, redirect handling, and token response validation remain unchanged.
Validation
pnpm run lint:checkpnpm run typecheckpnpm exec prettier --check(changed files)pnpm test— 68 files, 794 tests passed