fix(acp): honor per-session workspace roots - #785
Conversation
🦋 Changeset detectedLatest commit: 06bb73c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
dawn (@dawNotPoi) is attempting to deploy a commit to the LangChain Team on Vercel. A member of the Team first needs to authorize it. |
deepagents-acp
deepagents
@langchain/sandbox-standard-tests
@langchain/daytona
@langchain/deno
@langchain/modal
@langchain/node-vfs
@langchain/quickjs
commit: |
There was a problem hiding this comment.
The PR honors per-session workspace roots by accepting params.cwd from the ACP client, which expands the filesystem backend and terminal root to any client-supplied path; because ACP uses a stdio transport connecting a local IDE, this is a lower-severity concern than a typical network-facing path traversal, but remains a valid issue for deployments where the server is shared or the client is not fully trusted.
Problem
ACP clients provide a workspace in session/new.cwd, but the server ignored it and reused one agent/backend per configured agent. Filesystem operations could therefore run against the server process workspace, and concurrent sessions could share the wrong backend session ID.
Fix
Test
The standalone package typecheck still reports the pre-existing ACP SDK/backend type incompatibilities also present on main; this change adds no new diagnostics.
Closes #654