fix(deepagents): restrict filesystem paths to root - #665
Open
corridor-security[bot] wants to merge 3 commits into
Open
fix(deepagents): restrict filesystem paths to root#665corridor-security[bot] wants to merge 3 commits into
corridor-security[bot] wants to merge 3 commits into
Conversation
…rtualMode is disabled (default)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: d971d1f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
deepagents-acp
deepagents
@langchain/sandbox-standard-tests
@langchain/daytona
@langchain/deno
@langchain/modal
@langchain/node-vfs
@langchain/quickjs
commit: |
John Kennedy (jkennedyvz)
changed the title
# Conflicts: # libs/deepagents/src/backends/filesystem.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR was generated by Corridor to fix:
Changes
The fix closes a high-severity path traversal in FilesystemBackend.resolvePath when virtualMode is off by enforcing a root boundary in both modes. It hoists the traversal check to the top unconditionally and adds a non-virtual path containment check that resolves the absolute path and ensures it remains within this.cwd using path.relative, throwing if it escapes. Previously the non-virtual path accepted absolute paths and did not enforce containment; the virtual-mode behavior remains unchanged, and all 20 tests still pass.
Generated by Corridor