fix(test): tolerate 2- or 3-entry jumplist in jumplist.vimspec - #553
Conversation
Recent stable Neovim no longer records the extra jump when :edit replaces the fern buffer, so the jumplist holds only one fern:// entry instead of two. The test now accepts both the 3-entry shape (Vim / older Neovim) and the 2-entry shape (recent Neovim stable), while still asserting that alpha is preserved as the most distant jump in both cases. Fixes #549 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe test file ChangesVersion-Flexible Jumplist Assertions
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #549
Summary
>+ header), which assumed that leaving the fern buffer viaeditalways records twofern://entries.>+ header), causing the assertion to fail on CI.alphais retained as the most distant jump.Why
The behavioral difference is a Neovim internal change in how
editinteracts with the jumplist. Both the old (5-entry) and new (4-entry) shapes are correct from fern's perspective — what matters is that the jumplist is updated and thatalphasurvives as the oldest entry. Hard-coding the 5-entry shape made CI brittle against Neovim upgrades.Test Plan
🤖 Generated with Claude Code
Summary by CodeRabbit