Add -confirm and -immediate variants for clipboard-paste - #552
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughSplits the clipboard paste action into two variants (confirm-required and immediate) across dict and file schemes and updates documentation; handlers now accept a boolean flag to skip the move confirmation prompt. ChangesClipboard paste action split into confirm/immediate variants
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@doc/fern.txt`:
- Line 1309: Replace the misspelled word "defalut" with "default" in the
sentence containing "files (this is defalut), and the immediate variant skips
this prompt." so the text reads "files (this is default), and the immediate
variant skips this prompt."
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 93514b40-6ae9-48a0-baad-27d11ac1c1c4
📒 Files selected for processing (3)
autoload/fern/scheme/dict/mapping/clipboard.vimautoload/fern/scheme/file/mapping/clipboard.vimdoc/fern.txt
This change adds the following actions: ```vim <Plug>(fern-action-clipboard-paste-confirm) <Plug>(fern-action-clipboard-paste-immediate) ``` Where `-confirm` prompts the user for confirmation when moving a file and `-immediate` does not. `<Plug>(fern-action-clipboard-paste)` now maps to `<Plug>(fern-action-clipboard-paste-confirm)`, which was the default behavior of the clipboard paste action before this change. As such, this is not a breaking change. Fixes lambdalisue#551.
7f86797 to
eb7c524
Compare
|
CI failed but #549 so it's ok. |
|
Thanks a lot 🎉 |
This change adds the following actions:
Where
-confirmprompts the user for confirmation when moving a file and-immediatedoes not.<Plug>(fern-action-clipboard-paste)now maps to<Plug>(fern-action-clipboard-paste-confirm), which was the default behavior of the clipboard paste action before this change. As such, this is not a breaking change.Fixes #551.
Summary by CodeRabbit
New Features
Documentation