Skip to content

Feat: Update Auto Disconnect#301

Open
PoTheMagicDragon wants to merge 1 commit into
lambda-client:1.21.11from
PoTheMagicDragon:1.21.11
Open

Feat: Update Auto Disconnect#301
PoTheMagicDragon wants to merge 1 commit into
lambda-client:1.21.11from
PoTheMagicDragon:1.21.11

Conversation

@PoTheMagicDragon

@PoTheMagicDragon PoTheMagicDragon commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

This is a template, modify before submitting your PR

You can't make me

Description

  • Adds in options for sending invalid packets to force the server to kick you in case disconnecting alone doesn't work
  • Adds in a auto disconnect screen that includes a screenshot of when you were disconnected, details about the world and buttons for reconnecting, closing minecraft or going to the title/ server or world list screen.
    • Includes a setting for hiding details so coordinates/ time zone etc. aren't leaked when screensharing

Checklist Before Submitting

To ensure the quality and maintainability of your PR, confirm the following before submission:

  • Code adheres to the project's style guide and conventions.
    • Where do I find this?
  • All tests pass, including newly added tests.
  • Documentation has been updated to reflect any new features or changes.
    • Not sure what docs might need to be updated for this
  • Your PR is limited to a single purpose, avoiding unrelated changes.
Screenshot 2026-06-08 at 2 37 37 PM Screenshot 2026-06-08 at 2 38 46 PM Screenshot 2026-06-08 at 2 41 21 PM

@emyfops

emyfops commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Was AI used for this ?

@PoTheMagicDragon

Copy link
Copy Markdown
Contributor Author

Do you mind if I ask why is that important?

I feel like the more important questions are "Is this well written, does it handle necessary edge cases, does it add a meaningful feature and does it function well?"

@emyfops

emyfops commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Do you mind if I ask why is that important?

I feel like the more important questions are "Is this well written, does it handle necessary edge cases, does it add a meaningful feature and does it function well?"

It is pretty important to disclose the use of AI

@beanbag44

beanbag44 commented Jun 9, 2026

Copy link
Copy Markdown
Member

Do you mind if I ask why is that important?
I feel like the more important questions are "Is this well written, does it handle necessary edge cases, does it add a meaningful feature and does it function well?"

It is pretty important to disclose the use of AI

Why did you choose to phrase it in this way?

Was AI used for this ?

That just seems purposefully vague to force Po to explain himself when you've provided 0 feedback on the code itself.

If someone asked me if i used AI for any of the code in a pr i made, i would never lie about it, and im sure Po wouldn't either. However, wording the question like that just comes off as attacking for the sake of making the pr look worse.

@PoTheMagicDragon

Copy link
Copy Markdown
Contributor Author

It is pretty important to disclose the use of AI

There is no ai policy for Lambda and so I honestly shouldn't even be giving you an answer, but I want to be civil about it in hopes that you will be civil and open minded as well.

I have used ai to research, to generate small portions of code that I then modified, and to refine existing code with questions like "What edge cases have I not considered with X?". I understand what all of the code does and I feel like it is well written, handles all important edge cases, adds a meaningful feature, and it functions well. Almost all of the code here is a modified version of an auto disconnect I wrote for myself, but refined and upgraded to meet the standards I expect from Lambda. So yes, I used ai when working on this. Is it vibe coded? Very far from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants