Skip to content

fix(security): detect credentials after escaped boundaries #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vladimirrott merged 2 commits into from
Oct 19, 2026
Merged

fix(security): detect credentials after escaped boundaries #612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15cfa7b
fix(security): detect credentials after escaped boundaries
QinXi-ai Oct 17, 2026
cb30247
Merge branch 'main' into fix/601-escaped-secret-boundaries
vladimirrott Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions scripts/check_no_secrets.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,14 @@ ALLOWED_EXAMPLES=(
# provider:regex (POSIX ERE). Bodies are sized to the real format so fixtures
# fall short. Mistral has no distinctive prefix: only its named key assignment
# is recognized, rather than every unrelated 32-character identifier.
# Escaped whitespace and percent escapes end in alphanumerics, but still
# delimit a key in JSON logs and recorded HTTP exchanges.
PATTERNS=(
"Groq:gsk_[A-Za-z0-9]{40,}"
"OpenAI:(^|[^A-Za-z0-9_-])sk-[A-Za-z0-9_-]{40,}"
"OpenAI:(^|[^A-Za-z0-9_-]|\\\\[nrt]|%[0-9A-Fa-f]{2})sk-[A-Za-z0-9_-]{40,}"
"OpenAI project:sk-proj-[A-Za-z0-9_-]{40,}"
"Anthropic:sk-ant-[A-Za-z0-9_-]{40,}"
"DeepSeek:(^|[^A-Za-z0-9_-])sk-[A-Fa-f0-9]{32}([^A-Za-z0-9_-]|$)"
"DeepSeek:(^|[^A-Za-z0-9_-]|\\\\[nrt]|%[0-9A-Fa-f]{2})sk-[A-Fa-f0-9]{32}([^A-Za-z0-9_-]|$)"
"Mistral:(^|[^A-Za-z0-9_])MISTRAL_API_KEY[\"']?[[:space:]]*[=:][[:space:]]*[\"']?[A-Za-z0-9]{32}([^A-Za-z0-9_-]|$)"
"xAI:xai-[A-Za-z0-9]{70,}"
"GitHub PAT:ghp_[A-Za-z0-9]{36,}"
Expand Down
33 changes: 33 additions & 0 deletions tests/release/no-secrets.test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,20 @@ declare -a POSITIVES=(
"OpenAI|$(make_key 'sk-None-' 48)"
"OpenAI|$(make_key 'sk-svcacct-' 20)-$(make_key '' 19)_"
"OpenAI|$(make_key 'sk-' 20)_$(make_key '' 19)"
"OpenAI|Authorization: Bearer%20$(make_key 'sk-' 48)"
"OpenAI|log: \\n$(make_key 'sk-' 48)"
"OpenAI|log: \\r$(make_key 'sk-' 48)"
"OpenAI|log: \\t$(make_key 'sk-' 48)"
"OpenAI project|$(make_key 'sk-proj-' 64)"
"Anthropic|$(make_key 'sk-ant-' 95)"
"DeepSeek|$(make_key 'sk-' 32)"
"DeepSeek|DEEPSEEK_API_KEY=\"$(make_key 'sk-' 32)\""
"DeepSeek|\"DEEPSEEK_API_KEY\": \"$(make_key 'sk-' 32)\""
"DeepSeek|/$(make_key 'sk-' 32)"
"DeepSeek|Authorization: Bearer%20$(make_key 'sk-' 32)"
"DeepSeek|log: \\n$(make_key 'sk-' 32)"
"DeepSeek|log: \\r$(make_key 'sk-' 32)"
"DeepSeek|log: \\t$(make_key 'sk-' 32)"
"Mistral|MISTRAL_API_KEY = \"$(make_key '' 32)\""
"Mistral|'MISTRAL_API_KEY': '$(make_key '' 32)'"
"Mistral|\"MISTRAL_API_KEY\": \"$(make_key '' 32)\""
Expand Down Expand Up @@ -205,6 +213,7 @@ declare -a NEGATIVES=(
"$(make_key 'sk-' 31)" # Below DeepSeek's exact hexadecimal length
"sk-$(make_key '' 31)Z" # 32 characters, but not a DeepSeek hex body
"$(make_key 'sk-' 32)Z" # Do not match a 32-hex prefix of a longer token
"$(make_key 'sk-' 33)" # Above DeepSeek's length, below OpenAI's
"disk-$(make_key '' 32)" # An identifier containing sk- is not a key
"task-$(make_key '' 32)"
"prefixsk-$(make_key '' 32)"
Expand Down Expand Up @@ -342,6 +351,30 @@ else
fail=1
fi

# --- 5b. Modified files must be screened from the index, not the worktree ---
printf 'k = "%s"\n' "$leak" >> "$staged_repo/README.md"
git -C "$staged_repo" add README.md
if modified_output="$(cd "$staged_repo" && "$CHECK" --staged 2>&1)"; then
echo "FAIL: --staged accepted a credential added to an already tracked file"
fail=1
elif ! grep -Fq 'staged README.md' <<< "$modified_output"; then
echo "FAIL: --staged did not name the modified file it rejected"
fail=1
fi
printf 'clean\n' > "$staged_repo/README.md"
if (cd "$staged_repo" && "$CHECK" --staged > /dev/null 2>&1); then
echo "FAIL: --staged read the cleaned working tree, not the staged credential"
fail=1
fi
printf 'clean, edited\n' > "$staged_repo/README.md"
git -C "$staged_repo" add README.md
printf 'k = "%s"\n' "$leak" >> "$staged_repo/README.md"
if ! (cd "$staged_repo" && "$CHECK" --staged > /dev/null 2>&1); then
echo "FAIL: --staged rejected an unstaged working-tree edit the commit would not record"
fail=1
fi
git -C "$staged_repo" checkout -q HEAD -- README.md

# --- 6. A staged blob read failure must not masquerade as a finding ----------
fake_oid='1111111111111111111111111111111111111111'
git -C "$staged_repo" update-index --add --cacheinfo 100644,$fake_oid,unreadable.txt
Expand Down
Loading