fix(applaunchpad): rebind routes after service changes - #7213
Merged
Conversation
# Conflicts: # frontend/providers/applaunchpad/__tests__/unit/utils/deployYaml2Json.test.ts
cuisongliu
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clear stale bindings from routes that target the application's regenerated main Service when access mode, protocol, or imported network settings change. Preserve routes that explicitly target other backend Services, and keep default route ports synchronized with the regenerated Service. Add unit coverage for route rebinding and generated Ingress backends.
Sequence Diagram
sequenceDiagram participant User participant EditForm participant RouteBinding participant ManifestGenerator User->>EditForm: Change network topology or import settings EditForm->>RouteBinding: Rebind routes from the previous main Service alt Route targets the previous main Service RouteBinding-->>EditForm: Clear the stale Service name else Route targets an explicit external Service RouteBinding-->>EditForm: Preserve the explicit backend end EditForm->>ManifestGenerator: Generate Service and Ingress manifests ManifestGenerator-->>User: Ingress targets the regenerated main ServiceVerification
pnpm --filter applaunchpad lint,pnpm --filter applaunchpad exec tsc --noEmit --pretty false, andpnpm --filter applaunchpad buildpass. The focused Vitest command could not run because the installed dependency graph does not provide avitestexecutable.