Skip to content

fix(applaunchpad): rebind routes after service changes - #7213

Merged
cuisongliu merged 4 commits into
labring:release-v5.1from
mlhiter:ingress-svc
Aug 13, 2026
Merged

fix(applaunchpad): rebind routes after service changes#7213
cuisongliu merged 4 commits into
labring:release-v5.1from
mlhiter:ingress-svc

Conversation

@mlhiter

@mlhiter mlhiter commented Aug 13, 2026

Copy link
Copy Markdown
Member

Summary

Clear stale bindings from routes that target the application's regenerated main Service when access mode, protocol, or imported network settings change. Preserve routes that explicitly target other backend Services, and keep default route ports synchronized with the regenerated Service. Add unit coverage for route rebinding and generated Ingress backends.

Sequence Diagram

sequenceDiagram
    participant User
    participant EditForm
    participant RouteBinding
    participant ManifestGenerator

    User->>EditForm: Change network topology or import settings
    EditForm->>RouteBinding: Rebind routes from the previous main Service
    alt Route targets the previous main Service
        RouteBinding-->>EditForm: Clear the stale Service name
    else Route targets an explicit external Service
        RouteBinding-->>EditForm: Preserve the explicit backend
    end
    EditForm->>ManifestGenerator: Generate Service and Ingress manifests
    ManifestGenerator-->>User: Ingress targets the regenerated main Service
Loading

Verification

pnpm --filter applaunchpad lint, pnpm --filter applaunchpad exec tsc --noEmit --pretty false, and pnpm --filter applaunchpad build pass. The focused Vitest command could not run because the installed dependency graph does not provide a vitest executable.

# Conflicts:
#	frontend/providers/applaunchpad/__tests__/unit/utils/deployYaml2Json.test.ts
@mlhiter
mlhiter requested a review from a team as a code owner August 13, 2026 04:05
@mlhiter mlhiter added this to the v5.1 milestone Aug 13, 2026
@mlhiter
mlhiter requested a review from a team as a code owner August 13, 2026 06:25
@cuisongliu
cuisongliu merged commit d896fd1 into labring:release-v5.1 Aug 13, 2026
59 checks passed
@mlhiter
mlhiter deleted the ingress-svc branch August 14, 2026 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants