util/helper: fix process output getting truncated#1901
Open
zachdeibert wants to merge 1 commit into
Open
Conversation
A process that logs a lot of data before exiting could have its output truncated because ProcessWrapper used to stop reading the pipe once the process exits, but instead should always read to the end of the pipe. Signed-off-by: Zachary Deibert <Zachary.Deibert@garmin.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1901 +/- ##
======================================
Coverage 45.9% 45.9%
======================================
Files 180 180
Lines 14496 14496
======================================
Hits 6666 6666
Misses 7830 7830
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A process that logs a lot of data before exiting could have its output truncated because ProcessWrapper used to stop reading the pipe once the process exits, but instead should always read to the end of the pipe.
Checklist