Skip to content

Responsive navbar - #204

Open
ashenafykebede wants to merge 2 commits into
mainfrom
responsiveNavbar
Open

Responsive navbar#204
ashenafykebede wants to merge 2 commits into
mainfrom
responsiveNavbar

Conversation

@ashenafykebede

Copy link
Copy Markdown
Contributor

Checklists

General Checks

  • the branch is up to date with main/master
  • the code works when pulled and run locally
  • All CI checks pass
  • all conflicts are resolved (if any)
  • PR has a descriptive title
  • PR has appropriate labels and milestones for easy identification
  • PR it is assigned to the owner
  • reviewers are assigned
  • the PR contributes only one focused change
  • It is in the appropriate column in the project board (if necessary)
  • has short and clear description
  • is linked to an issue (if it is related)
  • feedback is addressed (if any and if it is appropriate feedback.)

Markdown

  • the markdown source is formatted
  • spelling and grammar is correct in all text
  • The markdown looks correct when you preview the file
  • all links and images work
  • any embedded code snippets are formatted

Comment thread snippets/html-css/responsive-navbar.md Outdated

/* Toggle between adding and removing the "responsive" class to topnav when the user clicks on the icon */

function toggleFun() {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like a website if you had to click a button in order to see the menu properly styled on your mobile device? Seems like an unnecessary extra step, no? 🙂

The point of media queries is that the browser automatically knows how to style elements depending on the screen width. There's actually no need for js in this snippet.

@gelilaa

gelilaa commented Jan 6, 2022

Copy link
Copy Markdown
Member

@ashenafykebede can you please resolve the conversation and correct the lint fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants