Responsive navbar - #204
Open
ashenafykebede wants to merge 2 commits into
Open
Conversation
arnochauveau
requested changes
Dec 14, 2021
|
|
||
| /* Toggle between adding and removing the "responsive" class to topnav when the user clicks on the icon */ | ||
|
|
||
| function toggleFun() { |
Member
There was a problem hiding this comment.
Would you like a website if you had to click a button in order to see the menu properly styled on your mobile device? Seems like an unnecessary extra step, no? 🙂
The point of media queries is that the browser automatically knows how to style elements depending on the screen width. There's actually no need for js in this snippet.
Member
|
@ashenafykebede can you please resolve the conversation and correct the lint fail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklists
General Checks
main/masterMarkdown