Skip to content

Ban - #196

Open
alimtunc wants to merge 1 commit into
l3mpire:masterfrom
Refty:ban
Open

Ban#196
alimtunc wants to merge 1 commit into
l3mpire:masterfrom
Refty:ban

Conversation

@alimtunc

@alimtunc alimtunc commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

DO NOT MERGE IF #163 ISN'T MERGED

Adding ban feature on report modal

Capture d’écran 2022-11-02 à 17 12 59

@Donorhan

Donorhan commented Nov 4, 2022

Copy link
Copy Markdown
Contributor

I merged the #163, it was impossible to merge a PR on another from a PR coming from a fork. But it causes a conflict, if you don't have time I can take care of the rebase 🙂

@alimtunc

alimtunc commented Nov 7, 2022

Copy link
Copy Markdown
Contributor Author

@Donorhan Should be good now 🙂

@ramnes ramnes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "Report & Ban" button is weird. As an admin, I want to ban users that have been reported to me, not report users that I ban. Also, it would make the "ban" button hard to find. Can we put that button on the users list just like the one to kick users? Ideally we'd also want the button in the reports we receive. Maybe we can also add both the "kick" and "ban" buttons in the radial menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants