Skip to content

Cascade rbac rule deletion#2133

Open
Hubtrick-Git wants to merge 4 commits into
mainfrom
cascade-rbac-rule-deletion
Open

Cascade rbac rule deletion#2133
Hubtrick-Git wants to merge 4 commits into
mainfrom
cascade-rbac-rule-deletion

Conversation

@Hubtrick-Git

Copy link
Copy Markdown
Collaborator

Now when an org or project or assets get deleted all associated RBAC rules get deleted as well.

Comment thread controllers/org_controller.go Outdated
Comment thread accesscontrol/casbin_rbac.go
Comment thread controllers/delete_rbac_cleanup_test.go
…plain rbac pattern matching, added integration test for core functionality of the implemented changes

@timbastin timbastin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a migration to delete all not used casbin rules as well. We have deployments which are already running since some time and those already accumulated a lot of non necessary rules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants