Create 1st.md#6
Open
kzhra wants to merge 4 commits into
Open
Conversation
hayashi-ay
reviewed
Jul 13, 2024
hayashi-ay
left a comment
hayashi-ay
left a comment
There was a problem hiding this comment.
良いと思います。PRのタイトルで問題が分かるようになっていると嬉しいです。
個人的には先に子について処理してから、自身をswapする方が処理を脳内でトレースしやすいですが、好みですかねー
oda
reviewed
Jul 13, 2024
| } | ||
|
|
||
| swap(root->left, root->right); | ||
| if (root->left) { |
oda
reviewed
Jul 13, 2024
|
|
||
| while (!unvisited.empty()) { | ||
| TreeNode* current = unvisited.front(); | ||
| unvisited.pop(); |
There was a problem hiding this comment.
全部 queue にいれてしまって、ここで、current の nullptr チェックをする手もあります。
colorbox
reviewed
Jul 14, 2024
| current_node->right = nullptr; | ||
| node_queue.push(current_node->left); | ||
| } else { | ||
| continue; |
hayashi-ay
reviewed
Jul 16, 2024
| TreeNode* current = unvisited.front(); | ||
| unvisited.pop(); | ||
|
|
||
| if (current) { |
There was a problem hiding this comment.
currentがnullptrだったら早めに抜けてあげることで、ネストを浅くできると思います。
if (current) {
continue;
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/invert-binary-tree/description/