fix: add standard labels to CRDs#96
Open
Suhani95 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Suhani <suhani4630@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the kyverno-api Helm chart’s CRD templates so that generated CRDs include a consistent set of standard Helm/Kubernetes labels even when .Values.labels is empty, while still supporting user-provided custom labels.
Changes:
- Updated the
kyverno-api.labelshelper to emit standardapp.kubernetes.io/*andhelm.sh/chartlabels by default. - Preserved support for user-defined
.Values.labelsvia templating (tpl) so custom labels can still be injected.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Suhani <suhani4630@gmail.com>
Suhani95
force-pushed
the
fix/crd-standard-labels-clean
branch
from
1bb88b5 to
d316ad4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR fixes an issue where CRDs generated by the kyverno-api Helm chart were rendered without standard Helm/Kubernetes labels when no custom labels were provided. It adds the default labels used across other Kyverno charts while preserving support for user-defined labels
Related issue
Fixes #71
Proposed Changes
Add standard Helm/Kubernetes labels to the
kyverno-api.labelshelper.Preserve existing
.Values.labelssupport for custom labels.Ensure all generated CRDs receive consistent metadata labels.
Verification
helm template test-release .helm lint .Verified that generated CRDs now include standard labels and the chart renders successfully.
Checklist
Further Comments
N/A