Skip to content

Oneko Sleeps in different locations on progress bar!#10

Open
Jenyyk wants to merge 5 commits into
kyrie25:mainfrom
Jenyyk:change-sleep-pos
Open

Oneko Sleeps in different locations on progress bar!#10
Jenyyk wants to merge 5 commits into
kyrie25:mainfrom
Jenyyk:change-sleep-pos

Conversation

@Jenyyk

@Jenyyk Jenyyk commented Feb 10, 2025

Copy link
Copy Markdown

Oneko now sleeps in the closest point on the bar!
As in if she is to the left, she sleeps on the left side, if she is in the middle, she sleeps in the middle, etc.
This somewhat addresses #2
Gif demonstration:
Screencast from 2025-02-10 10-36-18
apologies for the terrible quality

Comment thread oneko.js Outdated
@Jenyyk

Jenyyk commented Feb 10, 2025

Copy link
Copy Markdown
Author

All requested changes made!

@Jenyyk
Jenyyk requested a review from kyrie25 February 10, 2025 20:07

@kyrie25 kyrie25 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you've tested the new diff at all. 🫤
All these issues are breaking and very easy to see early on using the extension. Please do NOT submit AI-generated code else I'd have to close this PR.

Comment thread oneko.js Outdated
Comment thread oneko.js Outdated
@Jenyyk
Jenyyk requested a review from kyrie25 February 11, 2025 11:22
@Jenyyk

Jenyyk commented Mar 9, 2025

Copy link
Copy Markdown
Author

Hi @kyrie25,
Could you re-review this PR? I believe all the issues are fixed.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants