docs: correct the docs against what actually ships - #78
Conversation
An accuracy pass over README, CONTRIBUTING, RELEASING, SECURITY and the GitHub Pages landing page. Several claims had drifted from the code: - `cargo test` was documented as the test command, but the root package is the binary, so it silently skips every crate under `crates/` where most of the logic tests live. Now `cargo test --workspace`, with the reason. - CONTRIBUTING's clippy line was missing `--workspace --all-features`, so a local run could pass while CI failed on the same code. - RELEASING claimed the release job packages macOS, Linux and Windows. It packages two macOS zips; the other two are commented out in release.yml. Also dropped the pre-1.0 SemVer section (Kyde is 2.5.0) and documented that release-please owns two version fields, not one. - README listed caret-follow scrolling as missing (it ships), the menu bar as three items, Push without Pull/Fetch, and file management as New File / Rename / Delete (2.5.0 added cut/copy/paste, drag & drop, folder rename, the non-git guard). - Features that shipped but were never documented: worktree switcher (its screenshot was already in the repo, unused), compare two files, ⌘-click navigation, error squiggles, sort ops, back/forward, What's New, the in-app updater, single-instance launches, the light + CVD palettes. - SECURITY pointed at `src/git.rs` (now `crates/kyde-git`), still said pre-1.0, and didn't cover the updater or the single-instance socket. - The landing page told users to strip the quarantine attribute from a build that is Developer ID signed, notarized and stapled. Docs only — no code touched. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
🤖 AI Review: 🧹 Ship it, nits insideA thorough accuracy pass over all five doc files — README, CONTRIBUTING, RELEASING, SECURITY, and the landing page — checking every factual claim against the actual code. Every correction I spot-checked is accurate: paths, crate counts, feature presence, shortcut bindings, CI flags, release artifacts, and the six shipped palettes all match. The quarantine removal is justified (the release is signed and notarized). Solid housekeeping.
🧹 Nits
📝 Walkthrough
Product take: This is a significant documentation quality improvement. The README was trailing reality by several features and two major versions — anyone evaluating Kyde from the repo page was getting a materially incomplete picture. The SECURITY threat model additions (updater, socket) are the kind of thing that matters if a researcher comes knocking. 🧭 Assumptions & unverified claims
A docs PR this honest about what actually ships is rarer than it should be — nice work. · reviewed at 0ba7941 1 finding(s) anchored outside the diff (not posted inline)
The Getting Started section above now uses |
What
An accuracy pass over
README.md,CONTRIBUTING.md,RELEASING.md,SECURITY.mdand the GitHub Pages landing page, checking every factual claim against the code. Docs only — no code touched.Wrong, now fixed
cargo testruns the test suitecargo testskips every crate undercrates/. Nowcargo test --workspace, with the reason spelled out (README + CONTRIBUTING).cargo clippy --all-targets -- -D warnings--workspace --all-targets --all-features. The documented command could pass locally while CI failed.kyde-macos.zip,kyde-macos-x86_64.zip) +.sha256, signed/notarized/stapled. Linux and Windows are commented out inrelease.yml.0.x…"[package]+[workspace.package]viaextra-files), not one.reveal_pending). Soft-wrap is the real gap, and only in the file editor.src/git.rs, "pre-1.0"crates/kyde-git/src/lib.rs; the version line is gone.xattr -dr com.apple.quarantineShipped but undocumented, now covered
Worktree switcher (its screenshot was already committed but unused), compare two files, ⌘-click navigation, error squiggles, Sort Lines / Sort Object Keys, back/forward navigation, What's New, the in-app updater, single-instance launches, and the light + colour-vision-deficiency palettes. Missing shortcuts added to the keymap list (
⌘⇧F,⌘⌥←/→,⌥⌘L/⌥⌘S,⌃`).SECURITY's threat model also gained the in-app updater and the single-instance socket.
Testing
Docs only, no code changed, so nothing to run beyond reading the rendered diff.
Note
SECURITY.mdstill listskyle.johnson@flagsmith.comas the contact — left alone deliberately. Change it if that's stale.🤖 Generated with Claude Code