Replace hardcoded ASIO SDK path with FetchContent - #1042
Merged
Conversation
- Add FetchContent for ASIO SDK in cmake/Element.cmake - Use asiosdk_SOURCE_DIR instead of hardcoded USER_HOME_DIRECTORY path - Pin to specific commit for reproducible builds - Only fetch on Windows when ELEMENT_ENABLE_ASIO is enabled
glenandrewbrown
pushed a commit
to glenandrewbrown/element
that referenced
this pull request
Aug 23, 2026
* Replace hardcoded ASIO SDK path with FetchContent - Add FetchContent for ASIO SDK in cmake/Element.cmake - Use asiosdk_SOURCE_DIR instead of hardcoded USER_HOME_DIRECTORY path - Pin to specific commit for reproducible builds - Only fetch on Windows when ELEMENT_ENABLE_ASIO is enabled - fix: update expected script count in ScanDirectory test - feat: enable ASIO support in CMake configuration for Windows build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1039