fix: restore livestream starts fallback for episodes missing pubdate tags#57
Merged
Conversation
Only 2 of 8 visible episodes have pubdate tags. The May 6 and 4/29 episodes have none, so they fall back to created_at which is wrong. Now conditionally fetches livestream starts (3s timeout, non-blocking) only when any episode is missing a pubdate tag. Once all episodes get pubdate tags via sync pipeline, the extra query is skipped entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #56 removed livestream starts queries entirely, but only 2 of 8 visible episodes have pubdate tags. The rest (May 6, 4/29, 4/8, 3/19, 4/15, 4/22) fall back to created_at which is wrong.
This restores livestream starts as a conditional fallback — only fetched (3s timeout, non-blocking) when episodes are missing pubdate tags. Performance is still improved since the query skips entirely when all episodes have pubdate tags.