fix: delete dialog freeze — defer AlertDialog after DropdownMenu closes#38
Merged
Conversation
Root cause: clicking Delete in DropdownMenu immediately set deletingReport, opening AlertDialog while DropdownMenu's DismissableLayer was still active. The two radix layers conflicted, leaving pointer-events blocked after close. Fix: setTimeout(0) on the onDelete callback so the DropdownMenu finishes its close animation before AlertDialog opens. Also simplifies back to direct fire-and-forget delete (no pendingDelete/useEffect needed).
kurt-croix
force-pushed
the
fix/delete-freeze-v2
branch
from
April 30, 2026 20:07
e68b6fa to
72fdd27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: clicking Delete in the DropdownMenu immediately set deletingReport state, opening the AlertDialog while the DropdownMenu's DismissableLayer was still active. The two radix dismissable layers conflicted, leaving pointer-events blocked on the rest of the page after the AlertDialog closed.
Fix:
setTimeout(0)on the onDelete callback so the DropdownMenu finishes its close animation before the AlertDialog opens. No more layer conflict.