This repository was archived by the owner on Dec 9, 2025. It is now read-only.
#33 allows to force ios js banner instead of native banner using options#66
Closed
GabLeRoux wants to merge 0 commit into
Closed
#33 allows to force ios js banner instead of native banner using options#66GabLeRoux wants to merge 0 commit into
GabLeRoux wants to merge 0 commit into
Conversation
Collaborator
Author
|
Ah that's the same as #60 anyway, I suppose both changes work just fine. Is this still maintained? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did this, it seems to work fine now. you can specify the ios app-id and if specified, it will display the js. This allows us to controll when and how we display this banner even tho we can't provide a way to open the app directly going trough the store is reasonable. Thanks for this banner gold mine 👍