add new overlay csi func test#578
Conversation
involves edits to sync and test.sh scripts to deploy the overlay configuration when env var is set Signed-off-by: dsanatar <dsanatar@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
awels
left a comment
There was a problem hiding this comment.
looks good one question on the test. Would it make sense to check on the host itself if the directory that mounts the nfs is actually mounting the NFS share. You could check if the total space matches the total space of the NFS share. That would verify that the bind mount was successful and we are writing in the proper location. It is an extra check and probably not 100% needed, but something to consider
Signed-off-by: dsanatar <dsanatar@redhat.com>
What this PR does / why we need it:
Enables functional tests to be run in overlay csi configuration by new CI runner:
This also adds new storage pool test that is exclusively run in the csi overlay configuration that aims to regression test a case that was found from kubevirt/hostpath-provisioner-operator#721
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: