Skip to content

add new overlay csi func test#578

Open
dsanatar wants to merge 2 commits into
kubevirt:mainfrom
dsanatar:csi-overlay-func-tests
Open

add new overlay csi func test#578
dsanatar wants to merge 2 commits into
kubevirt:mainfrom
dsanatar:csi-overlay-func-tests

Conversation

@dsanatar

@dsanatar dsanatar commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Enables functional tests to be run in overlay csi configuration by new CI runner:

This also adds new storage pool test that is exclusively run in the csi overlay configuration that aims to regression test a case that was found from kubevirt/hostpath-provisioner-operator#721

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

involves edits to sync and test.sh scripts to deploy
the overlay configuration when env var is set

Signed-off-by: dsanatar <dsanatar@redhat.com>
@kubevirt-prow kubevirt-prow Bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 8, 2026
@kubevirt-prow

kubevirt-prow Bot commented Jul 8, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign akalenyu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-prow kubevirt-prow Bot requested review from akalenyu and awels July 8, 2026 15:10
@kubevirt-prow kubevirt-prow Bot added the size/L label Jul 8, 2026

@awels awels left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good one question on the test. Would it make sense to check on the host itself if the directory that mounts the nfs is actually mounting the NFS share. You could check if the total space matches the total space of the NFS share. That would verify that the bind mount was successful and we are writing in the proper location. It is an extra check and probably not 100% needed, but something to consider

Signed-off-by: dsanatar <dsanatar@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants