Skip to content

pass component prerelease image tag to E2E tests#86

Merged
bvolovat merged 1 commit into
mainfrom
fix/pass-component-image-tags
Apr 13, 2026
Merged

pass component prerelease image tag to E2E tests#86
bvolovat merged 1 commit into
mainfrom
fix/pass-component-image-tags

Conversation

@bvolovat

@bvolovat bvolovat commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Pass the prerelease image tag via component_image_tags in the E2E dispatch payload so system tests run against the actual built image instead of the default release
  • Removes charts_name from the dispatch (receiver already defaults it to kubescape-operator) to stay within GitHub's 10 top-level key limit on client_payload
  • Companion PRs: armosec/shared-workflows (forward COMPONENT_IMAGE_TAGS in receiver) and kubescape/node-agent (same change in its local workflow copy)

How it works

The dispatch now includes component_image_tags=<component>-tag=<prerelease-version> (e.g., operator-tag=v0.2.42-prerelease). The receiver forwards it to b-run-system-tests-self-hosted.yaml which already supports COMPONENT_IMAGE_TAGS and appends it to --kwargs for systest-cli.py.

Test plan

  • Merge armosec/shared-workflows companion PR first (receiver must forward the new field)
  • Trigger a component PR merge and verify the dispatch includes component_image_tags
  • Verify system tests install the helm chart with the prerelease image override

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated CI workflow for dispatching system tests: the dispatched payload now includes component image tag information and removes an obsolete payload field, with payload ordering adjusted. This refines how test runs are triggered without changing test groups or target branches.

@coderabbitai

coderabbitai Bot commented Mar 31, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c1cef747-c23e-413d-b563-e7dd61d929f2

📥 Commits

Reviewing files that changed from the base of the PR and between c0db9f3 and 48063ca.

📒 Files selected for processing (1)
  • .github/workflows/incluster-comp-pr-merged.yaml
✅ Files skipped from review due to trivial changes (1)
  • .github/workflows/incluster-comp-pr-merged.yaml

📝 Walkthrough

Walkthrough

Modified .github/workflows/incluster-comp-pr-merged.yaml to adjust the repository_dispatch client_payload: removed charts_name, retained charts_repo, and added component_image_tags set to ${{ inputs.COMPONENT_NAME }}-tag=${{ needs.docker-build.outputs.IMAGE_TAG_PRERELEASE }}.

Changes

Cohort / File(s) Summary
GitHub Workflow Dispatch Configuration
.github/workflows/incluster-comp-pr-merged.yaml
Updated the client_payload in the "Dispatch system tests to private repo" step: removed charts_name, kept charts_repo, added component_image_tags = ${{ inputs.COMPONENT_NAME }}-tag=${{ needs.docker-build.outputs.IMAGE_TAG_PRERELEASE }}; reordered payload fields accordingly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • Naor-Armo

Poem

🐰 A rabbit hops through CI so spry,
I tuck away charts_name, let tags fly high,
Component images wear new names with cheer,
Dispatching tests — the path is clear! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and directly describes the main change: passing the component prerelease image tag to E2E tests through the dispatch payload, which is the primary objective of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pass-component-image-tags

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

1 similar comment
@github-actions

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

Replace the hardcoded charts_name (already defaulted in the receiver)
with component_image_tags so system tests run against the actual
pre-release image instead of the default release.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: bvolovat <borisv@armosec.io>
@bvolovat
bvolovat force-pushed the fix/pass-component-image-tags branch from c0db9f3 to 48063ca Compare April 5, 2026 15:34
@github-actions

github-actions Bot commented Apr 5, 2026

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

1 similar comment
@github-actions

github-actions Bot commented Apr 5, 2026

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

@bvolovat
bvolovat merged commit 093e4fb into main Apr 13, 2026
11 checks passed
@matthyx matthyx moved this to To Archive in KS PRs tracking Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants