fix(backend): repair NewProducerMessage signature + self-loop tagging (unblocks component-tests)

[matthyx]

Overview

The component-tests matrix had been failing on every PR (including #163). There were two distinct regressions, both introduced by the MQ-extraction refactor (3d79f17), which this PR fixes. All 17 component-tests now pass.

1. Compile break (build failed)

3d79f17 changed the signature of the exported helper adapters/backend/v1.NewProducerMessage, dropping the leading producerMessageKey argument. That helper is consumed outside this repo by github.com/armosec/event-ingester-service (synchronizer_producer), which the integration tests module builds against local synchronizer via replace. The argument mismatch made the whole tests module fail to compile, so every component-test died at the Run test step before executing:

event-ingester-service/synchronizer_producer/producer.go:210:
  cannot use eventType (string) as []byte value in argument to backend.NewProducerMessage
FAIL github.com/kubescape/synchronizer/tests [build failed]

Fix: restore the producerMessageKey parameter; synchronizer's own two callers pass messaging.SynchronizerServerProducerKey.

2. Self-loop filter dropped external producers' messages (runtime failure)

Once compilation was restored, the tests ran but backend->cluster cases still failed (e.g. TC01: configmaps "test" not found). The refactor also added a self-loop guard — the reader skips messages where messaging.IsSelfProducedMessage is true — and BuildProducerProperties unconditionally stamps x-producer-source: synchronizer-server on every message it builds. Since NewProducerMessage is also used by external producers (event-ingester), their messages were tagged as self-produced and silently dropped by the server, so objects never landed in the cluster.

Fix: only stamp the self-produced source header when the caller is the synchronizer server itself (identified by SynchronizerServerProducerKey); strip it for any other producer key. Added a unit test covering both directions.

Verification

• go build ./..., go test ./adapters/backend/v1/, go test ./messaging/ — all pass locally.
• New unit test TestNewProducerMessage_SelfLoopTagging asserts external-producer messages are not tagged self-produced and are not filtered.
• CI: all 17 component-tests pass on this branch (previously all failing).

Once merged to main, other open PRs (e.g. #163) will pass component-tests after a rebase.

Generated with Claude Code

[coderabbitai]

📝 Walkthrough

Walkthrough

NewProducerMessage now accepts an explicit Pulsar message key and assigns it to the produced message. ProduceMessage passes messaging.SynchronizerServerProducerKey when constructing messages.

Changes

Pulsar message key handling

Layer / File(s)	Summary
Explicit key propagation adapters/backend/v1/pulsar.go	NewProducerMessage accepts and assigns the provided producer key, while ProduceMessage supplies the synchronizer server producer key.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly reflects the signature fix and caller key-tagging change, and it matches the PR’s main purpose.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/restore-producer-message-key

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Summary:

• License scan: success
• Credentials scan: failure
• Vulnerabilities scan: failure
• Unit test: success
• Go linting: failure

[github-actions]

Summary:

• License scan: success
• Credentials scan: failure
• Vulnerabilities scan: failure
• Unit test: success
• Go linting: failure