Repository navigation
test(pulsar): speed up integration tests and reduce image footprint - #112
Merged
matthyx merged 1 commit intoSep 9, 2026
Merged
Conversation
Signed-off-by: Gaurav Chaudhary <chaudharygaurav2004@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
matthyx
approved these changes
Sep 9, 2026
matthyx
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the Testcontainers migration, unit/integration split, cleanup paths, exported suite compatibility, and CI wiring. No blocking findings. Verified locally at 0b92789 with go test ./..., go test -race ./..., go vet ./..., go mod tidy -diff, and the tagged Pulsar integration suites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closes #111.
This PR separates broker-independent unit tests from tests that require a real Pulsar broker. Unit tests now use focused mocks and run
without Docker, while real broker behavior is tested through Testcontainers under the
integrationbuild tag.Changes
apachepulsar/pulsar:2.11.0toapachepulsar/pulsar:4.0.13.PulsarTestSuiteto the shared Testcontainers implementation.AppPortStartandAdminPortStart, updating them with the resolved host ports during setup.go.mod.Result
go test ./...no longer requires a Docker daemon.Compatibility note
PulsarTestSuite.AppPortStartandAdminPortStartremain publicly available for source compatibility. Testcontainers now selectscollision-free ports and replaces these fields with the resolved host ports during
SetupSuite; values assigned before setup no longercontrol port selection.
Verification