aws: Add Amazon ECR dual-stack endpoints for IPv6 support

[tom1ackerman]

Adds the Amazon ECR dual-stack registry hostnames (*.dkr-ecr.*.on.aws, *.dkr-ecr.*.on.amazonwebservices.com.cn, *.dkr-ecr-fips.*.on.aws) to the matchImages list of the ECR kubelet credential provider. Until now, kubelet did not call ecr-credential-provider for images on these hostnames, so pulls of private images from them failed unless credentials came from elsewhere, such as imagePullSecrets. See Making requests to Amazon ECR registries.

Only registry requests use the dual-stack hostnames. The plugin still requests the token from api.ecr.<region>.amazonaws.com, which is IPv4-only, so on IPv6-only nodes that request goes through NAT64, the same as for the existing ECR hostnames.

ecr-credential-provider supports these hostnames since v1.32.0 and v1.31.5 (kubernetes/cloud-provider-aws#1069), and kOps installs v1.37.0 by default. The new entries match the EKS AMI list.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: tom1ackerman / name: tom1ackerman (da1be14)

[kubernetes-prow]

Welcome @tom1ackerman!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[kubernetes-prow]

Hi @tom1ackerman. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[hakman]

/ok-to-test

[hakman]

/retest

[hakman]

Thanks @tom1ackerman!
/lgtm
/approve

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [hakman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hakman]

/override deploy/netlify "Header rules" "Pages changed" "Redirect rules"

[kubernetes-prow]

@hakman: Overrode contexts on behalf of hakman: Header rules, Pages changed, Redirect rules, deploy/netlify

Details

In response to this:

/override deploy/netlify "Header rules" "Pages changed" "Redirect rules"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.