Skip to content

feat: add nlb HealthCheckHttpVersion annotation#489

Open
Bowser1704 wants to merge 1 commit into
kubernetes:masterfrom
Bowser1704:feat/nlb-health-check-type
Open

feat: add nlb HealthCheckHttpVersion annotation#489
Bowser1704 wants to merge 1 commit into
kubernetes:masterfrom
Bowser1704:feat/nlb-health-check-type

Conversation

@Bowser1704

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds a new annotation service.beta.kubernetes.io/alibaba-cloud-loadbalancer-health-check-http-version to allow users to specify the HTTP protocol version (HTTP1.0 or HTTP1.1) for NLB health checks. The value is applied to the ServerGroup's HealthCheckConfig.HealthCheckHttpVersion on create, update, and reconcile.

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NLB health checks now support configuring HTTP protocol version via the `service.beta.kubernetes.io/alibaba-cloud-loadbalancer-health-check-http-version` annotation (values: `HTTP1.0`, `HTTP1.1`).

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@kubernetes-prow kubernetes-prow Bot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 3, 2026
@kubernetes-prow

Copy link
Copy Markdown

Hi @Bowser1704. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 3, 2026
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Bowser1704
Once this PR has been reviewed and has the lgtm label, please assign aoxn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot requested review from aoxn and gujingit July 3, 2026 08:38
Signed-off-by: Hongqi Yu <bowser1704@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant