Skip to content

✨ Add metadata to OpenStackClusterTemplate.spec - #3278

Open
nikParasyr wants to merge 1 commit into
kubernetes-sigs:mainfrom
nikParasyr:clusterclass_metadata
Open

✨ Add metadata to OpenStackClusterTemplate.spec#3278
nikParasyr wants to merge 1 commit into
kubernetes-sigs:mainfrom
nikParasyr:clusterclass_metadata

Conversation

@nikParasyr

@nikParasyr nikParasyr commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Add metadata to OpenStackClusterTemplate.spec to fully conform with the contract.
The contract is documented here

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3277

Special notes for your reviewer:

  1. I was going through the contract for a different provider and noticed that we are missing this. This is not a major addition but ensures we conform to the contract.
  2. I believe we can add this to the 0.15.alpha releases but up for discussion

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2026
@netlify

netlify Bot commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit b20b961
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/6a69bfa87d91aa00082605e6
😎 Deploy Preview https://deploy-preview-3278--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 24, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from mandre and smoshiur1237 July 24, 2026 10:04
@nikParasyr
nikParasyr force-pushed the clusterclass_metadata branch from 1af6459 to a446069 Compare July 24, 2026 10:18
@nikParasyr nikParasyr mentioned this pull request Jul 24, 2026
Open
8 tasks
@nikParasyr
nikParasyr force-pushed the clusterclass_metadata branch from a446069 to 1daecaf Compare July 24, 2026 10:23
@nikParasyr

nikParasyr commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@nikParasyr

nikParasyr commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@nikParasyr

nikParasyr commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

/cc @bnallapeta @lentzi90

@kubernetes-prow
kubernetes-prow Bot requested review from bnallapeta and lentzi90 July 24, 2026 12:24
lentzi90
lentzi90 reviewed Jul 29, 2026
View reviewed changes

@lentzi90 lentzi90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!
It looks good to me except the docs seem duplicated. I guess the intent was to add a section about API additions, separate from changes? Now it looks more like only API additions twice, followed by changes without its own header.

Comment thread docs/book/src/topics/crd-changes/v1beta1-to-v1beta2.md Outdated
@nikParasyr
Add metadata to OpenStackClusterTemplate.spec
b20b961 
Add metadata to OpenStackClusterTemplate.spec to fully
conform with the contract
@nikParasyr
nikParasyr force-pushed the clusterclass_metadata branch from 1daecaf to b20b961 Compare July 29, 2026 08:53
lentzi90
lentzi90 reviewed Jul 29, 2026
View reviewed changes

@lentzi90 lentzi90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
We could consider backporting this also, but I would not do it unless there is demand for it.

@kubernetes-prow

kubernetes-prow Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lentzi90 lentzi90 lentzi90 left review comments
@mandre mandre Awaiting requested review from mandre
@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237
@bnallapeta bnallapeta Awaiting requested review from bnallapeta

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

CAPO Roadmap
Status: Inbox

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

✨ v1beta2 Support spec.metadata on OpenStackClusterTemplate

2 participants

@nikParasyr @lentzi90