Skip to content

🌱 Verify cloudbuild image exists and works - #3236

Open
lentzi90 wants to merge 1 commit into
kubernetes-sigs:mainfrom
Nordix:lentzi90/verify-cloudbuild
Open

🌱 Verify cloudbuild image exists and works#3236
lentzi90 wants to merge 1 commit into
kubernetes-sigs:mainfrom
Nordix:lentzi90/verify-cloudbuild

Conversation

@lentzi90

@lentzi90 lentzi90 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

These images are now pruned after some days. We need to verify that we use images that exists and works as part of CI. Otherwise we risk finding out only after pushing a tag...

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Related issue kubernetes/k8s.io#9599

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2026
@netlify

netlify Bot commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 5cfa4aa
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/6a3bbfca8e40dc00089736fe
😎 Deploy Preview https://deploy-preview-3236--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubernetes-prow
kubernetes-prow Bot requested review from EmilienM and stephenfin June 24, 2026 07:17
@kubernetes-prow kubernetes-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 24, 2026
@lentzi90
lentzi90 force-pushed the lentzi90/verify-cloudbuild branch from 6d9a7e8 to e83e531 Compare June 24, 2026 07:28
@lentzi90
Verify cloudbuild image exists and works
5cfa4aa 
These images are now pruned after some days. We need to verify that we
use images that exists and works as part of CI. Otherwise we risk
finding out only after pushing a tag...

Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@lentzi90
lentzi90 force-pushed the lentzi90/verify-cloudbuild branch from e83e531 to 26a5fac Compare June 24, 2026 08:12
@kubernetes-prow kubernetes-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 24, 2026
@lentzi90 lentzi90 mentioned this pull request Jun 24, 2026
Merged
@lentzi90

lentzi90 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Let's wait for kubernetes/test-infra#37323. Then this should work without the extra commit.

@lentzi90
lentzi90 force-pushed the lentzi90/verify-cloudbuild branch from 26a5fac to 5cfa4aa Compare June 24, 2026 11:30
@kubernetes-prow kubernetes-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 24, 2026
lentzi90
lentzi90 commented Jun 24, 2026
View reviewed changes

@lentzi90 lentzi90 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold cancel
It works 🎉
However, I think it is not fool proof. We merge the release notes to the main branch and then the build happens on the release branch. The pre-submit job for the main branch will not catch an issue on the release branch.
There is also the timing issue. If we are unlucky we can see this job pass on a PR and then when it actually merges the image no longer exists.
It is still better than nothing and we can set up perodic jobs to catch build issues on all supported branches daily.

@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2026
@kubernetes-prow

kubernetes-prow Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2026
@lentzi90

lentzi90 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Created #3239 for followup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmilienM EmilienM Awaiting requested review from EmilienM
@stephenfin stephenfin Awaiting requested review from stephenfin

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

CAPO Roadmap
Status: Inbox

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lentzi90