Fixed wrong default for frontend-nlb-eip-allocations in annotation docs - #4871
Fixed wrong default for frontend-nlb-eip-allocations in annotation docs#4871dominikhei wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dominikhei The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @dominikhei. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4871 +/- ##
==========================================
+ Coverage 57.49% 57.50% +0.01%
==========================================
Files 396 396
Lines 31621 31673 +52
==========================================
+ Hits 18179 18213 +34
- Misses 12384 12401 +17
- Partials 1058 1059 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
The
frontend-nlb-eip-allocationsannotation is incorrectly showing 200 as its default value in the annotation reference table. However this annotation has no default, it is optional and defaults to N/A.Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯