Add AuditTokenRequest extended API storage#420
Merged
Conversation
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
tamalsaha
changed the title
Wires a new natscredentialrequests resource under identity.k8s.appscode.com/v1alpha1 by delegating to the b3 identity client's GetNatsCredential method. Modelled on the existing inboxtokenrequest storage. Vendor bump is hand-applied and will be replaced by a normal go mod vendor once the resource-metadata change lands. Signed-off-by: Tamal Saha <tamal@appscode.com>
No behavior change — storage still calls GetNatsCredential, which now delegates to the new method. Signed-off-by: Tamal Saha <tamal@appscode.com>
Signed-off-by: Tamal Saha <tamal@appscode.com>
Signed-off-by: Tamal Saha <tamal@appscode.com>
…ction" This reverts commit 395bef7. Signed-off-by: Tamal Saha <tamal@appscode.com>
Signed-off-by: Tamal Saha <tamal@appscode.com>
Signed-off-by: Tamal Saha <tamal@appscode.com>
Signed-off-by: Tamal Saha <tamal@appscode.com>
tamalsaha
force-pushed
the
feat-natscredentialrequest
branch
from
b1517e1 to
2274f78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
audittokenrequestsresource underidentity.k8s.appscode.com/v1alpha1.*identity.Client.GetAuditToken, modelled afterinboxtokenrequest.kmodules.xyz/resource-metadatato the merged master commit (ba20b6454).Why
The audit lib (
go.bytebuilders.dev/audit) talks directly toappscode.com/api/v1/registerfor NATS credentials. Disconnected clusters can't reach that endpoint. The ui-server already proxies appscode-hub calls through theb3identity client, so it's the natural place to host an extended API that audit (and any other in-cluster caller) can hit instead.Depends on
Test plan
go build ./...kubectl create -fanAuditTokenRequestand confirm the response carriesnatsServer,natsSubject, and a credential blob