ci: ignore authenticated Slack links in the markdown link check - #873
Open
Yetkin Timocin (ytimocin) wants to merge 1 commit into
Open
Yetkin Timocin (ytimocin) wants to merge 1 commit into
Yetkin Timocin (ytimocin) wants to merge 1 commit into
Conversation
cloud-native.slack.com/archives/* answers 403 to unauthenticated requests, so the README's Slack channel link fails the link checker on any PR that touches a markdown file, and intermittently on main. The link is correct; the checker cannot follow it. Ignore the archives path the same way mailto: links are ignored. Azure/fleet already carries this ignore (dbbe3c9c). Signed-off-by: Yetkin Timocin <ytimocin@microsoft.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README's Slack channel link (
cloud-native.slack.com/archives/...) returns 403 to unauthenticated requests, somarkdown-link-checkfails on any PR that touches a markdown file and intermittently onmain. The link is correct; the checker cannot follow it.This ignores the
archives/path the same waymailto:links are already ignored. Azure/fleet carries the same ignore (Azure/fleet@dbbe3c9c).Currently blocking a green check on #822, #823, and #824.