Harden release workflow: packages:write, fetch-depth:0, ghcr.io login#59
Merged
Conversation
- Add `permissions: packages: write` to the build job so the workflow's GITHUB_TOKEN can push to ghcr.io. - Add `fetch-depth: 0` to the actions/checkout step so the full history is available for version derivation (e.g. `git describe`). - Switch container-registry login to ghcr.io with `github.actor` / `GITHUB_TOKEN` via docker/login-action (replacing prior 1gtm / DOCKERHUB_TOKEN, and any inline `docker login` shell command). Signed-off-by: Tamal Saha <tamal@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
permissions: packages: writeon the build job so the workflow'sGITHUB_TOKENcan push images to the org's ghcr.io packages.with: fetch-depth: 0to theactions/checkoutstep so the full git history is available (e.g. forgit describeinmake version).${{ github.actor }}/${{ secrets.GITHUB_TOKEN }}viadocker/login-action(replacing1gtm/DOCKERHUB_TOKEN, and any inlinedocker loginshell command).Required follow-up before next release
On the ghcr.io package settings page (Org → Packages →
<this image>→ Package settings → Manage Actions access), add this repo with role Write (or Admin). Without that,GITHUB_TOKENwill hitpermission_denied: write_packageon push.Test plan
ghcr.io/kubedb/<image>.🤖 Generated with Claude Code