feat: renovate support for kubara catalogs - #533
Open
tuunit wants to merge 1 commit into
Open
Conversation
tuunit
force-pushed
the
feat/renovate-support-for-catalogs
branch
from
July 29, 2026 08:26
5a8a780 to
e1bcdaf
Compare
Signed-off-by: Jan Larwig <jan@larwig.com>
tuunit
force-pushed
the
feat/renovate-support-for-catalogs
branch
from
July 29, 2026 08:26
e1bcdaf to
2dfe415
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds first-class Renovate support for keeping OCI catalog references up to date, by (1) documenting a Renovate custom manager configuration and (2) auto-generating a renovate.json alongside the config when running kubara init.
Changes:
- Generate a
renovate.jsonduringkubara init(newensureRenovateConfighelper). - Document a Renovate custom manager + package rules configuration for catalog OCI references.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/cmd/init.go |
Adds automatic renovate.json generation during init and the underlying generator logic. |
docs/content/2_concepts/catalog_distribution.md |
Adds an example Renovate config for automatic catalog updates. |
Comments suppressed due to low confidence (1)
src/cmd/init.go:276
ensureRenovateConfigis executed before the "config already exists" short-circuit and before env validation. As a result,kubara initcan writerenovate.jsoneven when it subsequently returns an error (e.g., invalid env). Consider generating it only in the success paths (existing config, or after building the new cluster) instead of unconditionally at the top.
if err := o.ensureRenovateConfig(cs); err != nil {
return err
}
if fileExists {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+234
to
238
| if err := o.ensureRenovateConfig(cs); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if err := workflow.CreateOrUpdateCluster(cs.GetConfig(), es.GetConfig(), o.catalogLoadOptions()); err != nil { |
| %q | ||
| ], | ||
| "matchStrings": [ | ||
| "oci:\\/\\/(?<depName>[^:\\s\"'`+"`"+`]+):(?<currentValue>[^\\s\"'`+"`"+`]+)" |
| "customType": "regex", | ||
| "description": "Update kubara catalog OCI references", | ||
| "fileMatch": ["(^|/)config\\.yaml$"], | ||
| "matchStrings": ["oci:\\/\\/(?<depName>[^:\\s\"'\\`]+):(?<currentValue>[^\\s\"'\\`]+)"], |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
docs/content/2_concepts/catalog_distribution.md:203
- The Renovate JSON example escapes the backtick as
\\`` inside the regex character class, which makes the shown regex differ from the one generated bykubara init` and adds an unnecessary escape sequence for Renovate's JS regex engine. Keeping the example aligned with the generated config avoids copy/paste confusion.
"matchStrings": ["oci:\\/\\/(?<depName>[^:\\s\"'\\`]+):(?<currentValue>[^\\s\"'\\`]+)"],
src/cmd/init.go:274
ensureRenovateConfigruns before theenvValidateErrearly-return in normal mode, sokubara initcan generaterenovate.jsoneven when init ultimately fails due to invalid env and no config is written. This leaves partial side effects on error paths.
if err := o.ensureRenovateConfig(cs); err != nil {
return err
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
kubara init🧩 Type of change
🧪 Testing
🔗 Additional Context / Related Issues / Tickets
✅ Checklist