Skip to content

fix(render): use portable paths for embedded templates - #503

Open
BittuBarnwal7479 wants to merge 1 commit into
kubara-io:mainfrom
BittuBarnwal7479:fix/windows-embedded-template-paths
Open

fix(render): use portable paths for embedded templates#503
BittuBarnwal7479 wants to merge 1 commit into
kubara-io:mainfrom
BittuBarnwal7479:fix/windows-embedded-template-paths

Conversation

@BittuBarnwal7479

@BittuBarnwal7479 BittuBarnwal7479 commented Jul 17, 2026

Copy link
Copy Markdown

📝 Summary

Fix built-in Helm and Terraform template discovery on Windows by using path.Join instead of filepath.Join for paths consumed by embed.FS.

embed.FS implements Go's io/fs, which always expects forward-slash (/) separated paths regardless of the operating system. This change restores correct template loading on Windows while preserving existing behavior on Linux and macOS.

🧩 Type of change

  • 🔧 CLI / Go code
  • 📦 Helm chart
  • 🧱 Terraform module
  • 📝 Documentation
  • 🧪 Test or CI change
  • ♻️ Refactor / cleanup

⚠️ Is this a breaking change?

  • Yes, this change breaks existing functionality (explain in summary)
    No. This only fixes Windows compatibility for embedded template discovery and does not change generated artifacts or catalog contents.

🧪 Testing

  • CI passed
  • Manually tested (local/dev cluster)
  • Unit tested
  • Not tested (explain why below)

🔗 Related Issues / Tickets

Fixes: #502

✅ Checklist

  • Code compiles and passes all tests
  • Linting and style checks pass
  • Comments added for complex logic
  • Documentation updated (if applicable)

📎 Additional Context (optional)

Before:
image

After:
image

@BittuBarnwal7479
BittuBarnwal7479 requested a review from a team July 17, 2026 22:00
@tuunit
tuunit force-pushed the fix/windows-embedded-template-paths branch from e9a3731 to c95bf87 Compare July 22, 2026 14:22
@tuunit

tuunit commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@BittuBarnwal7479 thank you for the PR we didn't have the time yet to check it properly and check the rest of the codebase for similar issues related to windows support. We will try to get it into the next release in 2 weeks. Until then we recommend running/using the kubara cli inside WSL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Built-in catalog templates cannot be loaded on Windows

2 participants