Skip to content

docs: document repository auth modes - #389

Closed
Matthiator wants to merge 7 commits into
feat/argocd-repo-auth-modesfrom
feat/argocd-repo-external-secret-auth
Closed

docs: document repository auth modes#389
Matthiator wants to merge 7 commits into
feat/argocd-repo-auth-modesfrom
feat/argocd-repo-external-secret-auth

Conversation

@Matthiator

@Matthiator Matthiator commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Review order: This PR is stacked on #388. Please review and merge #388 first.

📝 Summary

Documents how additional Argo CD application repositories use the authentication modes introduced by #388.

  • documents HTTPS username plus password/PAT credentials
  • documents SSH deploy keys and host-key requirements
  • documents GitHub App credentials and the optional GitHub Enterprise base URL
  • uses the current platform-configs/<cluster>/helm/argo-cd/values-additional.yaml path

The reusable ExternalSecret template implementation was removed from this PR and moved to kubara-io/catalogs#6.

🧩 Type of change

  • 🔧 CLI / Go code
  • 📦 Helm chart
  • 🧱 Terraform module
  • 📝 Documentation
  • 🧪 Test or CI change
  • ♻️ Refactor / cleanup

⚠️ Is this a breaking change?

  • Yes, this change breaks existing functionality (explain in summary)

🧪 Testing

  • CI passed
  • Manually tested (local/dev cluster)
  • Unit tested
  • Not tested (explain why below)

Validated with strict documentation validation and a documentation build.

🔗 Related Issues / Tickets

Related to #246
Related to #388
Related to kubara-io/catalogs#6

✅ Checklist

  • Code compiles and passes all tests
  • Linting and style checks pass
  • Comments added for complex logic
  • Documentation updated (if applicable)

📎 Additional Context (optional)

This PR intentionally contains documentation only; the catalog implementation is reviewed separately in kubara-io/catalogs#6.

@Matthiator
Matthiator marked this pull request as ready for review June 9, 2026 17:49
@Matthiator
Matthiator requested review from la-cc and tuunit June 9, 2026 17:50
@tuunit

tuunit commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

move template change to catalogs repository

@Matthiator Matthiator changed the title feat: support repository auth modes in ExternalSecret helper docs: document repository auth modes Jul 22, 2026
@Matthiator

Copy link
Copy Markdown
Contributor Author

Done: the template change was moved to kubara-io/catalogs#6. This PR now contains only the matching workload-onboarding documentation.

@Matthiator

Copy link
Copy Markdown
Contributor Author

The documentation changes from this PR have been moved into #388 so the repository authentication feature and its user documentation can be reviewed together. The reusable template implementation remains in kubara-io/catalogs#6. Closing this stacked PR as superseded by #388.

@Matthiator Matthiator closed this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants