Repository navigation
Keep numpad Add distinct from the main-row plus key [patch] - #200
Merged
Merged
Conversation
Numpad Add was the only numpad key folded into a main-row alias, so Ctrl+Add fired Ctrl+Plus while Ctrl+Subtract, Decimal, Multiply, Divide and NumPad0-9 stayed distinct. Drop ADD from the + alias so every numpad key can be bound separately, and pin that in KeyAliasEquivalenceTests. Fixes #197 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW6CpCSCzyWrJduFwhr
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #197
What changed
Note.CanonicalizeKeyfoldedADD, the WinForms/WPF name for numpad plus, into+. None of the other numpad keys were folded. As a result,Ctrl+AddmatchedCtrl+Plus, butCtrl+Subtractdidn't matchCtrl+Minus, and numpad plus couldn't be bound on its own.I took the safer option from the triage and dropped
ADDfrom the+alias. Now every numpad key (Add,Subtract,Decimal,Multiply,Divide,NumPad0–9) stays distinct from its main-row counterpart, and a comment at the alias table records the rule.Tests
KeyAliasEquivalenceTests.NumpadKey_StaysDistinctFromTheMainRowKey. It pinsAdd,Subtract,Decimal,Multiply,DivideandNumPad1as distinct from+,-,.,*,/and1.Ctrl+Addrow fails ("Expected values to differ").Keybinding.Testsuite passes: 308/308.Generated by Claude Code