feat: support refresh command for latest FITELnet - #3871
Open
SeiyaFunaokaJP wants to merge 2 commits into
Open
Conversation
Owner
|
@SeiyaFunaokaJP Are there any documents from the vendor on this behavior? "refresh" is a bit of a strange command here. |
Owner
|
@SeiyaFunaokaJP I have separately fixed the pyasn issue. |
Contributor
Author
|
@ktbyers Thank you for reviewing. This is the vendor document. (There is not the English version) translation: Workflow: running.cfg = Running configuration
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
FITELnet routers keep an uncommitted candidate configuration (
working.cfg) that has to beapplied before it becomes the running configuration (
running.cfg). Depending on the model /firmware, the CLI command that performs this is either
commitorrefresh.The driver currently implements
commit()only. On platforms wherecommitis not available,users have to fall back to
send_command("refresh")and re-implement the confirmation-prompthandling and the FITELnet-specific error detection themselves.
This PR extracts the shared apply logic into a private helper and adds a
refresh()methodnext to the existing
commit().Testing
develop.sample code for testing
Sample codeResult:
ruff and mypy pass log