Use a user-data-dir in temp space while testing vscode tooling#395
Closed
joeslice wants to merge 1 commit into
Closed
Use a user-data-dir in temp space while testing vscode tooling#395joeslice wants to merge 1 commit into
joeslice wants to merge 1 commit into
Conversation
Running the vscode tests causes userdata to be stored near the test itself. When kson is cloned into a deep subdirectory (or just a long path) and we issue a build & test the userdata may be stored in a path that's longer than 103 characters causing a warning that in fact fails the tests. Using os.tmpdir() instead stores the user data in a subdirectory of a platform-specific location such as /tmp, /usr/tmp, C:\temp, etc. allowing us to expect short enough paths to avoid this warning.
Contributor
Author
|
Heh, superceded by #394 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the vscode tests causes userdata to be stored near the test itself. When kson is cloned into a deep subdirectory (or just a long path) and we issue a build & test the userdata may be stored in a path that's longer than 103 characters causing a warning that in fact fails the tests. Using os.tmpdir() instead stores the user data in a subdirectory of a platform-specific location such as /tmp, /usr/tmp, C:\temp, etc. allowing us to expect short enough paths to avoid this warning.