code review file for Pruthviraj#198
Open
pbutiya wants to merge 3 commits into
Open
Conversation
kishore223
reviewed
Feb 16, 2023
| def language_Function(): | ||
| print("") | ||
| print("****************************************************************PLEASE SELECT LANGAUGE **********************************") | ||
| print("********* 1."+languageList[0]) |
There was a problem hiding this comment.
Instead of using '+' operator, use string formatting.
kishore223
reviewed
Feb 16, 2023
| str = inputString | ||
| fLetter = str[:1] | ||
| sLetter = str[1:2] | ||
| if fLetter== "T" or fLetter== "t" or fLetter== "N" or fLetter== "n": |
There was a problem hiding this comment.
Use 'in' operator to simply code.
kishore223
reviewed
Feb 16, 2023
| exit_Function() | ||
|
|
||
|
|
||
| if inputString=="2": # For TURKISH OR AZERBAIJANI |
There was a problem hiding this comment.
It is better to use elif statements, as this will improve the performance of the code.
kscanne
reviewed
Feb 23, 2023
| select_Function() | ||
|
|
||
| # Logic for each langauge, In future more langauges can be added and their logic can be written. | ||
| def select_Function(): |
Owner
There was a problem hiding this comment.
I don't really like the design of this code — you've mixed the logic for lowercasing with a bunch of user-interface menu code. This is not "modular" is the positive sense we've discussed in class. Could you refactor what you have into a single Python function that takes two strings as arguments (a string to lowercase and a BCP-47 code)? See the homework specification for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.